chore: migrate persistence to async SQLDelight on JS [WPB-23964]#3982
Draft
chore: migrate persistence to async SQLDelight on JS [WPB-23964]#3982
Conversation
Contributor
Test Results4 342 tests - 380 4 300 ✅ - 305 8m 2s ⏱️ + 5m 10s For more details on these failures, see this check. Results for commit d3bde34. ± Comparison against base commit fb16f31. This pull request removes 4722 and adds 4342 tests. Note that renamed tests count towards both.This pull request removes 117 skipped tests and adds 20 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://wearezeta.atlassian.net/browse/WPB-23964
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
Issues
web-worker-driver, but the persistence layer still assumed synchronous generated SQLDelight APIs.IllegalStateException: The driver used with SQLDelight is asynchronous, so SQLDelight should be configured for asynchronous usage.generateAsync = truefor Kalium databases caused broad compile fallout because DAO, bootstrap, and helper code still depended on synchronous query access patterns.Causes (Optional)
Solutions
UserDatabaseandGlobalDatabaseindata:persistence.suspendwhere required through DAOs and helpers.nuke, DB path, empty file creation) so the remaining non-native parity gaps are explicit.