Skip to content

feat(typing): send typing indicator event tests pt3. (WPB-4590)#2122

Merged
yamilmedina merged 7 commits intofeat/enqueue-send-typing-and-deletefrom
feat/enqueue-send-typing-and-delete-tests
Oct 10, 2023
Merged

feat(typing): send typing indicator event tests pt3. (WPB-4590)#2122
yamilmedina merged 7 commits intofeat/enqueue-send-typing-and-deletefrom
feat/enqueue-send-typing-and-delete-tests

Conversation

@yamilmedina
Copy link
Copy Markdown
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Refactor and split repositories, and create a periodic cleanup of orphaned typing indicators, so we clean those after some time.

Needs releases with:

Testing

Test Coverage (Optional)

Coverage for PR


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2023

Unit Test Results

   405 files  +2     405 suites  +2   21s ⏱️ -1s
2 216 tests +6  2 136 ✔️ +6  80 💤 ±0  0 ±0 

Results for commit a30cf8c. ± Comparison against base commit 171b473.

♻️ This comment has been updated with latest results.

@yamilmedina yamilmedina merged commit a9089a9 into feat/enqueue-send-typing-and-delete Oct 10, 2023
@yamilmedina yamilmedina deleted the feat/enqueue-send-typing-and-delete-tests branch October 10, 2023 11:14
yamilmedina added a commit that referenced this pull request Oct 10, 2023
…pt2. (WPB-4590) (#2121)

* feat: mapper and repo ops deletion

* chore: ip

* chore: some fun refactoring, just ideas

* chore: some fun refactoring, just ideas

* chore: some fun refactoring, just ideas

* chore: working base

* chore: clear indicators

* chore: clear indicators

* chore: clear indicators

* chore: notes

* chore: refactor into new classes splitted

* chore: comments cleanup

* chore: detekt fixes

* Empty-Commit

* feat(typing): send typing indicator event tests pt3. (WPB-4590) (#2122)

* chore: test cov

* chore: test cov

* chore: test cov

* chore: test cov

* chore: test cov
yamilmedina added a commit that referenced this pull request Oct 10, 2023
…-4590) (#2118)

* fix: exclude selfuser from typingevents

* fix: exclude selfuser from typingevents

* fix: coverage for flag check

* chore: api configuration for sending typing status

* chore: api configuration for sending typing status v0

* chore: api configuration for sending typing status v0

* chore: pr comments

* feat: mapper and repo ops

* feat: mapper and repo ops

* feat: mapper and repo ops

* chore: detekt

* chore: detekt

* chore: tests broken

* feat(typing): send typing indicator events use case and cleanup code pt2. (WPB-4590) (#2121)

* feat: mapper and repo ops deletion

* chore: ip

* chore: some fun refactoring, just ideas

* chore: some fun refactoring, just ideas

* chore: some fun refactoring, just ideas

* chore: working base

* chore: clear indicators

* chore: clear indicators

* chore: clear indicators

* chore: notes

* chore: refactor into new classes splitted

* chore: comments cleanup

* chore: detekt fixes

* Empty-Commit

* feat(typing): send typing indicator event tests pt3. (WPB-4590) (#2122)

* chore: test cov

* chore: test cov

* chore: test cov

* chore: test cov

* chore: test cov
github-merge-queue bot pushed a commit that referenced this pull request Oct 11, 2023
* feat(typing): send typing indicator events networking layer pt1. (WPB-4590) (#2118)

* fix: exclude selfuser from typingevents

* fix: exclude selfuser from typingevents

* fix: coverage for flag check

* chore: api configuration for sending typing status

* chore: api configuration for sending typing status v0

* chore: api configuration for sending typing status v0

* chore: pr comments

* feat: mapper and repo ops

* feat: mapper and repo ops

* feat: mapper and repo ops

* chore: detekt

* chore: detekt

* chore: tests broken

* feat(typing): send typing indicator events use case and cleanup code pt2. (WPB-4590) (#2121)

* feat: mapper and repo ops deletion

* chore: ip

* chore: some fun refactoring, just ideas

* chore: some fun refactoring, just ideas

* chore: some fun refactoring, just ideas

* chore: working base

* chore: clear indicators

* chore: clear indicators

* chore: clear indicators

* chore: notes

* chore: refactor into new classes splitted

* chore: comments cleanup

* chore: detekt fixes

* Empty-Commit

* feat(typing): send typing indicator event tests pt3. (WPB-4590) (#2122)

* chore: test cov

* chore: test cov

* chore: test cov

* chore: test cov

* chore: test cov

* fix: not block delay, to not block send stop

* feat: add missing usecase to clear reusing repository

* feat: add missing usecase to clear reusing repository
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.94%. Comparing base (171b473) to head (a30cf8c).

Files with missing lines Patch % Lines
.../data/conversation/TypingIndicatorSenderHandler.kt 0.00% 2 Missing ⚠️
...um/logic/feature/conversation/ConversationScope.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                            @@
##             feat/enqueue-send-typing-and-delete    #2122      +/-   ##
=========================================================================
+ Coverage                                  57.90%   57.94%   +0.04%     
  Complexity                                    24       24              
=========================================================================
  Files                                       1028     1028              
  Lines                                      38321    38321              
  Branches                                    3467     3467              
=========================================================================
+ Hits                                       22188    22207      +19     
+ Misses                                     14634    14615      -19     
  Partials                                    1499     1499              
Files with missing lines Coverage Δ
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)
.../data/conversation/TypingIndicatorSenderHandler.kt 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171b473...a30cf8c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: M type: feature ✨

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants