fix: prevent race conditions by creating new objects for repository configurations (#943)

* fix: prevent race conditions by creating new objects for repository configurations

Signed-off-by: Jan Bronicki <janbronicki@microsoft.com>

* Update lib/plugins/repository.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Signed-off-by: Jan Bronicki <janbronicki@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: John15321

lib/settings.js

@@ -327,11 +327,11 @@ ${this.results.reduce((x, y) => {
 
   async updateRepos (repo) {
     this.subOrgConfigs = this.subOrgConfigs || await this.getSubOrgConfigs()
-    // Keeping this as is instead of doing an object assign as that would cause `Cannot read properties of undefined (reading 'startsWith')` error
-    // Copilot code review would recoommend using object assign but that would cause the error
+    // Create a new object to avoid mutating the shared this.config.repository
+    // This prevents race conditions when multiple repos are processed concurrently via Promise.all
     let repoConfig = this.config.repository
     if (repoConfig) {
-      repoConfig = Object.assign(repoConfig, { name: repo.repo, org: repo.owner })
+      repoConfig = Object.assign({}, repoConfig, { name: repo.repo, org: repo.owner })
     }
 
     const subOrgConfig = this.getSubOrgConfig(repo.repo)
@@ -347,7 +347,8 @@ ${this.results.reduce((x, y) => {
     if (subOrgConfig) {
       let suborgRepoConfig = subOrgConfig.repository
       if (suborgRepoConfig) {
-        suborgRepoConfig = Object.assign(suborgRepoConfig, { name: repo.repo, org: repo.owner })
+        // Create a new object to avoid mutating the shared subOrgConfig.repository
+        suborgRepoConfig = Object.assign({}, suborgRepoConfig, { name: repo.repo, org: repo.owner })
         repoConfig = this.mergeDeep.mergeDeep({}, repoConfig, suborgRepoConfig)
       }
     }