gtest version conflict

[Timple]

Solution to issue cannot be found in the documentation.

• I checked the documentation.

Issue

Gtest failure:

48.74 In file included from /app/.pixi/envs/default/src/gtest_vendor/src/gtest-all.cc:49:
48.74 /app/.pixi/envs/default/src/gtest_vendor/./src/gtest.cc:2720:1: error: no declaration matches 'testing::TestInfo::TestInfo(const std::string&, const std::string&, const char*, const char*, testing::internal::CodeLocation, testing::internal::TypeId, testing::internal::TestFactoryBase*)'
48.74  2720 | TestInfo::TestInfo(const std::string& a_test_suite_name,
48.74       | ^~~~~~~~
48.74 In file included from /app/.pixi/envs/default/src/gtest_vendor/src/gtest-all.cc:38:
48.74 /app/.pixi/envs/default/include/gtest/gtest.h:665:3: note: candidates are: 'testing::TestInfo::TestInfo(const testing::TestInfo&)'
48.74   665 |   TestInfo(const TestInfo&) = delete;
48.74       |   ^~~~~~~~
48.74 /app/.pixi/envs/default/include/gtest/gtest.h:618:3: note:                 'testing::TestInfo::TestInfo(std::string, std::string, const char*, const char*, testing::internal::CodeLocation, testing::internal::TypeId, testing::internal::TestFactoryBase*)'
48.74   618 |   TestInfo(std::string test_suite_name, std::string name,
48.74       |   ^~~~~~~~
48.74 /app/.pixi/envs/default/include/gtest/gtest.h:533:18: note: 'class testing::TestInfo' defined here
48.74   533 | class GTEST_API_ TestInfo {
48.74       |                  ^~~~~~~~

The TestInfo and TestSuite constructors changed their parameter types between 1.15 and 1.17
(from const std::string& to std::string by value). The vendored source and the installed
headers must be from the same version.

Expected Behaviour

ros-kilted-gtest-vendor should vendor gtest 1.17.x source to match the
gtest >=1.17.0 requirement declared by ros-kilted-ament-cmake-gtest.

Environment

• robostack-kilted channel
• ros-kilted-gtest-vendor: 1.15.1
• ros-kilted-ament-cmake-gtest: 2.7.4
• gtest (conda-forge): 1.17.0

Installed packages

$ mamba list
Command 'mamba' not found, did you mean:
  command 'samba' from deb samba (2:4.19.5+dfsg-4ubuntu9.4)

Environment info

https://github.com/Timple/pixi-trials/blob/main/pf_driver/pixi.toml

If cannot reproduce, try the Dockerfile

[Tobias-Fischer]

Looks like we need to unvendor gtest ..

[Timple]

I was under the impression with pixi less vendoring was needed. Because you can also depend on c++ package with a pixi.toml.

Or is this something that trickles down from the buildfarm?

[Tobias-Fischer]

Yes correct we do not want to (or in this case looks like we MUST NOT) vendor; but currently we do. @traversaro is the expert though

[traversaro]

I was under the impression with pixi less vendoring was needed. Because you can also depend on c++ package with a pixi.toml.

Or is this something that trickles down from the buildfarm?

Indeed, but we need to explicitly unvendor the gtest package, by passing the correct cmake options. To be honest, I did not even know that gtest was vendored in ROS. We should add the correct option to disable vendoring in gtest in https://github.com/RoboStack/ros-kilted/blob/main/pkg_additional_info.yaml, and add the correct dependency in dependencies.yaml.

[Timple]

Would this be as simple as adding:

gtest_vendor:
  additional_cmake_args: "-DAMENT_VENDOR_POLICY=NEVER_VENDOR_IGNORE_SATISFIED_CHECK"

to the file you propose? I have no idea (yet) how this all works 🙂

[traversaro]

Would this be as simple as adding:

gtest_vendor:
additional_cmake_args: "-DAMENT_VENDOR_POLICY=NEVER_VENDOR_IGNORE_SATISFIED_CHECK"

to the file you propose? I have no idea (yet) how this all works 🙂

Yes, and tipically also adding the correct dependencies in https://github.com/RoboStack/ros-kilted/blob/main/patch/dependencies.yaml .

[traversaro]

There was a wave of activity on this apparently today, not sure if this is related to this issue: ament/googletest#37 .

[mjcarroll]

I think it's mostly that Shane decided we don't need the vendor package anymore and made it happen :)

[traversaro]

I think it's mostly that Shane decided we don't need the vendor package anymore and made it happen :)

Thanks a lot @sloretz, that will simplify a lot our life!